Skip to content

Conversation

@dmehala
Copy link
Contributor

@dmehala dmehala commented Oct 24, 2025

Description

By default, ingress-nginx defines the /nginx_status endpoint. This configuration causes unnecessary traces to be sent to Datadog.

This commit updates the sampling rules to exclude traces originating from this endpoint.

Note to Reviewer

This change serves as a temporary workaround. In the long term, our module should be updated to avoid generating traces when stub_status is enabled.

@dmehala dmehala requested a review from a team as a code owner October 24, 2025 15:33
@dmehala dmehala force-pushed the dmehala/inginx-sample-out-stubstatus branch from f5ed224 to 9afd9b6 Compare October 24, 2025 15:45
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.42%. Comparing base (70273f4) to head (724f09b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/tracing_library.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   68.85%   68.42%   -0.44%     
==========================================
  Files          56       56              
  Lines        7389     6030    -1359     
  Branches     1049     1049              
==========================================
- Hits         5088     4126     -962     
+ Misses       1794     1397     -397     
  Partials      507      507              
Files with missing lines Coverage Δ
src/tracing_library.cpp 74.07% <0.00%> (-7.14%) ⬇️

... and 51 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmehala dmehala merged commit 9cdb72e into master Oct 28, 2025
87 checks passed
@dmehala dmehala deleted the dmehala/inginx-sample-out-stubstatus branch October 28, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants