work around DNS delays in ARM64 CI #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
reviewed
Oct 18, 2023
| default `gethostbyname()` resolver used by nginx will not use DNS.""" | ||
| script = f""" | ||
| for service in {" ".join(f"'{service}'" for service in services)}; do | ||
| getent hosts "$service" >>/etc/hosts |
There was a problem hiding this comment.
First time I encounter getent, interesting. I thought you would use docker inspect.
There was a problem hiding this comment.
docker inspect might be a better way. I'll have a look.
dmehala
force-pushed
the
dmehala/arm64-support
branch
3 times, most recently
from
7745d0a to
ef007f3
Compare
|
Thanks. I'll resolve the conflicts and merge after the ARM64 branch is merged into master. |
|
It has been cherry-picked in #45 . Thanks a lot @dgoffredo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nginx uses
gethostbyname()to look up IP addresses for upstreams (unless you designate a resolver). Both libc flavors (glibc and musl) as configured in our test images, will first check/etc/hostsbefore going to DNS. DNS sometimes takes five seconds (instead of the more typical < 1 ms), which causes a timeout in the tracing library, which causes tests to fail that are checking whether the tracer sent a trace to the Agent.This revision pre-populates the nginx container's
/etc/hostswith the otherdocker composeservices' IP addresses.