chore: enforce codestyle #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoffredo
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks! I've committed some updates, so please have a look.
We eventually might want to revisit whether we can do better than a Makefile in this repository. For now, let's continue to use it.
The format CI check is failing because the dd-trace-cpp CI image that you've reused doesn't have yapf3 in it. I think it's reasonable to add that to the apt-get install in dd-trace-cpp's Dockerfile and docker push it to the correct place. The ubuntu package is called yapf3. While we're at it, we can add Python formatting for the one .py file in dd-trace-cpp, or not.
Alternatively, if you have another approach, we can do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.