DD_SERVICE is overwritten with the application name

[yyamanoi1222]

Expected Behavior

if a value is set, DD_SERVICE is not overwritten.

Actual Behavior

DD_SERVICE is overwritten with the application name.

Steps to Reproduce the Problem

1. serverless.yml

service: serverless-dd
frameworkVersion: "3"

plugins:
  - serverless-plugin-datadog
provider:
  name: aws
  runtime: nodejs18.x
  environment:
    DD_SERVICE: 'test-app'
functions:
  hello:
    handler: handler.hello

2. Run sls deploy
3. Expected value of DD_SERVICE is "test-app" but, actually "serverlerss-dd"

Specifications

• Serverless Framework version: 3.36.0
• Datadog Serverless Plugin version: 5.52.0
• Lambda function runtime (Python 3.7, Node 10, etc.): nodejs18.x

Stacktrace

Paste here

[astuyve]

Hi, this library sets DD_SERVICE itself at the provider (whole project) level. If you'd like to override it, that can be done with the service tag as per the readme:

At this time we don't have an option to modify the service tag at the per-function level, but feel free to open a feature request for this capability.

I'm going to close this as I do not think it's a bug, but feel free to add a comment or re-open if I'm misunderstanding something.

Thank you!

[yyamanoi1222]

@astuyve
Thank you for your reply.
I think the code here says not to overwrite if DD_SERVICE is set at the provider level, but in fact this code will not work unless "custom.datadog.service" is set.
https://github.com/DataDog/serverless-plugin-datadog/blob/main/src/index.ts#L387-L389

If "custom.datadog.service" is not set, but DD_SERVICE is already set, i think it should not be overwritten.