Skip to content

Conversation

@stanleegoodspeed
Copy link
Collaborator

@stanleegoodspeed stanleegoodspeed commented Dec 5, 2022

Description

This PR adds a new service called ads-java. It is basically a duplicate of the existing ads service except it's written in Java. The purpose here is to create a Java service so the container can be used to display Java profiling or any other DD product with a Java integration.

How to test

  1. Pull down this branch, run docker-compose up
  2. Go to frontend repo
  3. In env.local, switch the NEXT_PUBLIC_ADS_PORT to be 3030
  4. Start frontend
  5. Make sure ads continue to be served on the homepage

Before you move on, make sure that:

  • No unintended changes are included
  • Spelling is correct
  • There are tests covering new/changed functionality
  • Commits have meaningful names and changes. CR remarks-like commits are squashed.
  • Proper labels assigned. Use WIP label to indicate that state

@stanleegoodspeed stanleegoodspeed changed the title Add ads service in Java Create new ads service in Java Dec 5, 2022
Copy link
Contributor

@devindford devindford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, ads continue to load when port is changed to point at the java implementation

@stanleegoodspeed stanleegoodspeed marked this pull request as ready for review December 7, 2022 19:27
@stanleegoodspeed stanleegoodspeed merged commit 3ab9f28 into main Dec 7, 2022
@stanleegoodspeed stanleegoodspeed deleted the ccole/ads-to-java branch December 7, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants