Skip to content

Conversation

@stanleegoodspeed
Copy link
Collaborator

This will publish arm and amd versions of the images to fix some local build issues when using tagged ECR images. I tested the arm context locally via the following cmd:

docker build --platform linux/arm64 --tag public.ecr.aws/x2b9z2t7/storedog/backend:arm-test-1 --no-cache ./services/backend

Additionally I updated the docker compose to have the correct subnet CIDR block

Checklist

Before you move on, make sure that:

  • No unintended changes are included
  • Spelling is correct
  • There are tests covering new/changed functionality
  • Commits have meaningful names and changes. CR remarks-like commits are squashed.
  • Proper labels assigned. Use WIP label to indicate that state

Copy link
Contributor

@devindford devindford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple silicon 🙃

@stanleegoodspeed stanleegoodspeed merged commit 1d188ab into main Feb 3, 2023
@stanleegoodspeed stanleegoodspeed deleted the ccole/add-platform branch February 3, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants