Skip to content

Throw error in ads service via code flag #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 5, 2023
Merged

Throw error in ads service via code flag #38

merged 10 commits into from
Apr 5, 2023

Conversation

@stanleegoodspeed
Copy link
Collaborator

@stanleegoodspeed stanleegoodspeed commented Feb 28, 2023 •
edited
Loading

Description

https://datadoghq.atlassian.net/browse/WEB-3213

This PR updates the /ads route to optionally return an error. This is configured via the feature flag system code-stash, managed by the featureFlags.config.json file.

Note

  • console logs will be removed prior to merge
  • feature flag will be turned off prior to merge

How to test

  1. Pull down branch
  2. Rebuild frontend and ads service
    docker-compose build frontend ads
  3. Start the app via docker-compose up
  4. When all services are healthy, visit http://localhost
  5. Continue refreshing the homepage to generate errors
  6. In the logs for the ads service, you should see 500s
  7. You should also see 500s in the dev console of the browser

Expected APM traces view
Screen Shot 2023-04-05 at 1 22 02 PM

Expected Error tracking view
Screen Shot 2023-04-05 at 1 21 52 PM

@stanleegoodspeed stanleegoodspeed changed the title error tracking with code flag Throw error in ads service via code flag Feb 28, 2023
@stanleegoodspeed stanleegoodspeed marked this pull request as ready for review February 28, 2023 19:46
@stephen-w-pracy
Copy link
Contributor

stephen-w-pracy commented Apr 5, 2023

Can the flag be put in a header, instead of the URL path?

@stanleegoodspeed
Copy link
Collaborator Author

stanleegoodspeed commented Apr 5, 2023

@stevedatadog Yea that makes sense. PR is updated with X-Throw-Error flag

@stanleegoodspeed stanleegoodspeed merged commit 547a2a6 into main Apr 5, 2023
@stanleegoodspeed stanleegoodspeed deleted the ccole/error-tracking branch April 5, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spottsdd spottsdd Awaiting requested review from spottsdd

1 more reviewer

@stephen-w-pracy stephen-w-pracy stephen-w-pracy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stanleegoodspeed @stephen-w-pracy @devindford