Skip to content

feat: setup deploy job for multi platform frontend build #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2023
Merged

feat: setup deploy job for multi platform frontend build #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
519995c
feat: setup deploy job for multi platform frontend build
devindford Apr 11, 2023
7a45f8b
chore: udpate comment
devindford Apr 11, 2023
43cbdbf
fix: tagging convention
devindford Apr 11, 2023
246476e
feat: fix frontend to match
devindford Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
context: ./services/frontend
platforms: linux/amd64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/frontend:amd-latest
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/frontend:latest

- name: Build and push ARM
uses: docker/build-push-action@v2
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,19 @@ jobs:
for i in "${IMAGES[@]}"
do
echo "$i"

docker pull "$i":latest
docker tag "$i":latest "$i":$TAG
docker push "$i":$TAG

# Since frontend is images are build to be platform specific, we need to tag and deploy accordingly
if [[ "$i" == *"storedog/frontend"* ]]; then
# deploy frontend arm image
docker pull "$i":arm-latest
docker tag "$i":arm-latest "$i":arm-$TAG
docker push "$i":arm-$TAG
fi

done

echo "All done"
Expand Down
2 changes: 1 addition & 1 deletion services/frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ FROM node:16.18.0 as builder
WORKDIR /storedog-app
COPY . .
EXPOSE 3000
RUN ["yarn","install"]
RUN ["yarn","install"]