Skip to content

Create EC2 instance in ASG #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 20, 2023
Merged

Create EC2 instance in ASG #18

merged 17 commits into from
Dec 20, 2023

Conversation

@christophetd
Copy link
Contributor

@christophetd christophetd commented Dec 14, 2023 •
edited
Loading

Create the EC2 instance in an auto-scaling group of size 1 by default. This ensures that:

  • When (not if) the underlying AWS hardware fails, a new instance is automatically spin up
  • It's easy to renew instances by simply stopping one

Tagging works a bit differently with ASGs, but it's still working as expected:

image

(https://datadoghq.atlassian.net/browse/COMM-1733)

@christophetd christophetd changed the base branch from main to ssm December 14, 2023 09:30
@christophetd christophetd changed the base branch from ssm to main December 14, 2023 09:31
@christophetd christophetd marked this pull request as ready for review December 14, 2023 10:30
@christophetd christophetd requested review from a team as code owners December 14, 2023 10:30
@christophetd christophetd force-pushed the asg branch 2 times, most recently from f9d5c18 to 5eeb337 Compare December 14, 2023 10:49
brett0000FF
brett0000FF previously approved these changes Dec 14, 2023
View reviewed changes
jinroh
jinroh previously approved these changes Dec 18, 2023
View reviewed changes
@christophetd
Create EC2 instance in ASG
bf59b94
@christophetd
Create EC2 instance in ASG
15d9fe1
@christophetd
Remove outdated output and use toset
13dc34a
@christophetd
Fix launch template resource ID
afe9518
@christophetd
Fix iterator in dynamic block
b661d31
@christophetd
Remove extraneous AZ parameter in instance module (1 subnet = 1 AZ al…
239e6bc 
…ready)
@christophetd
base64-encode user data
43bc2f0
@christophetd
Align root device name with the AMI one
dd73196
@christophetd
Make scanner_version mandatory in user_data since it's always provide…
9bedaf0 
…d anyway
@christophetd
Set default scanner version at the top module level
55814c7
@christophetd
Autogenerate docs
7854285
@christophetd
Bump default version to match #19
c4333f7
@christophetd
Fix tagging for EC2 instance name
4462c81
@christophetd
Fix incorrect boolean default value
1266110
@christophetd
Have the ASG use the actual latest version from the launch template
b8495ce
@christophetd
Trigger instance refresh in the ASG when the launch template configur…
df29596 
…ation changes
@christophetd
Bump default version to match current main branch
17ef045
@christophetd christophetd dismissed stale reviews from jinroh and brett0000FF via 17ef045 December 20, 2023 10:34
@christophetd christophetd merged commit 01e4f70 into main Dec 20, 2023
@christophetd christophetd deleted the asg branch December 20, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinroh jinroh jinroh approved these changes

@brett0000FF brett0000FF brett0000FF left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christophetd @jinroh @brett0000FF