Use matching arn instead of resource to fix issue with order creation #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegate role must be created after the scanner role has been created, otherwise when referencing the ARN in the trust policy, AWS will replace it with an unique ID not matching the role we want to allow.
https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_policy-examples.html#example-delegate-xaccount-rolesapi
To avoid that side effect we use the condition
ArnLiketo match on the yet to be created policy.This is at the cost of a slight security risk. Since the matching is now done on the name, a malicious actor could delete role and recreate it in the scanner account.