Skip to content

Conversation

@jamiechandler99
Copy link
Contributor

Tested :

  • q 3.5 and up
  • Utility scripts supports python 3.8 and above - must have requests installed but is the only external requirement

Notes:
Unsure best way to have this data sourced. Python to me is the most lightweight and easily automatable but does not really fit the objective of a standalone q package. That being said one way or another this package will be reliant on external data. This to me seemed good to include, although maybe for actually shipping of this package its included more as an aside.

Other options for this would be building out the HTTP q library and see if I can replicate this logic in q alone. Will take a look at that

Copy link
Member

@jonathonmcmurray jonathonmcmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a tzinfo file in TorQ (I think it's just a q flat file) https://github.com/DataIntellectTech/TorQ/blob/master/config/tzinfo (based off Kx supplied data at https://github.com/KxSystems/cookbook/tree/master/timezones)

Would it make sense to include that instead of the python script etc.? I guess we might have to update it periodically if countries change observance of DST etc. but that's probably pretty minimal

@jamiechandler99
Copy link
Contributor Author

Updated to take from flat and provided steps for manual update. Have also aligned code with style.md taking this to be the golden source. Will also update other PRs to align as I work on them

Copy link
Member

@jonathonmcmurray jonathonmcmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor points & something I need to update in style guide

@jamiechandler99
Copy link
Contributor Author

Updated to reflect updated style guide for timezone ending brace, fixed unit test comments and added additional notes in doc that tzinfo is available by default and download steps are only needed for updating

@jamiechandler99 jamiechandler99 merged commit ac39676 into main Jul 25, 2025
@jamiechandler99 jamiechandler99 deleted the add_timezone_lib branch July 25, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants