CLL: Add impact radius of a column #17
Conversation
Signed-off-by: popcorny <celu@infuseai.io>
DaveFlynn
left a comment
DaveFlynn
left a comment
There was a problem hiding this comment.
Just one note about adding an explanation to the example section. Other than that, it's looks good.
|
|
||
| ### Example: Simplified Model Chain | ||
| {: .shadow} | ||
|
|
There was a problem hiding this comment.
Some textual explanation of the image would help, in addition to the raw SQL from the models.
To help the reader understand how CLL can help them to visualize the relations. Of course, they can figure it out from the SQL by themself, but we can speed that up with a brief, plain language, description
There was a problem hiding this comment.
I have updated the example segment. PTAL
ijac13
left a comment
ijac13
left a comment
There was a problem hiding this comment.
LGTM.
We may need to have a separate doc for impact radius
Signed-off-by: popcorny <celu@infuseai.io>
DaveFlynn
left a comment
DaveFlynn
left a comment
There was a problem hiding this comment.
Two sentence adjustments, other than that it's good to go!
Signed-off-by: popcorny <celu@infuseai.io>
We add the model-to-column dependencies, so we now can show the impact radius of a column