Skip to content

Conversation

@ijac13
Copy link
Contributor

@ijac13 ijac13 commented Jul 30, 2025

PLA-464

but I need help to update the icon with "Interactive Demos" on the navigation

@ijac13 ijac13 requested a review from gcko July 30, 2025 06:51
Copy link
Contributor

@gcko gcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ijac13 , please take a look at my suggestions. I recommend you do not link directly to Recce Demo from the navbar because it causes difficulty in ensuring the icon looks and feels correct.

I also recommend updating the text of the demo.md and index.md page using the suggestions I provided.

@ijac13
Copy link
Contributor Author

ijac13 commented Jul 30, 2025

per discussion with @gcko, we decided to take the suggestions. Don't spend too much effort do make the icon a special case. We'll later update the whole doc anyway.

Please review the update, @gcko. Thanks

Copy link
Contributor

@gcko gcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gcko gcko merged commit 5a43912 into main Jul 31, 2025
@gcko gcko deleted the update-demo-link branch July 31, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants