Fix: Column visibility buttons could cause columns that shouldn't have had a control button (through the columns option) to show a control button if used with ColReorder.

- DD-626

Author: AllanJard

js/buttons.colVis.js

@@ -108,6 +108,7 @@ $.extend( DataTable.ext.buttons, {
 		},
 		init: function ( dt, button, conf ) {
 			var that = this;
+			button.attr( 'data-cv-idx', conf.columns );
 
 			dt
 				.on( 'column-visibility.dt'+conf.namespace, function (e, settings) {
@@ -122,8 +123,17 @@ $.extend( DataTable.ext.buttons, {
 						return;
 					}
 
-					that.text( conf._columnText( dt, conf ) );
-					that.active( dt.column( conf.columns ).visible() );
+					conf.columns = $.inArray( conf.columns, details.mapping );
+					button.attr( 'data-cv-idx', conf.columns );
+
+					// Reorder buttons for new table order
+					button
+						.parent()
+						.children('[data-cv-idx]')
+						.sort( function (a, b) {
+							return (a.getAttribute('data-cv-idx')*1) - (b.getAttribute('data-cv-idx')*1);
+						} )
+						.appendTo(button.parent());
 				} );
 
 			this.active( dt.column( conf.columns ).visible() );