DEV-14278, DEV-14279 Address tfsec warnings and make example more complete. #11
Conversation
| } | ||
|
|
||
| resource "aws_security_group_rule" "tamr_vm" { | ||
| description = "Rule for ingress from Tamr VM to Postgres" |
There was a problem hiding this comment.
Idea for future improvement (out of scope for this ticket):
Probably don't need to be as prescriptive as we are in this module having a 1 vm + list of spark security group IDs.
Could probably just take a list that includes both.
There was a problem hiding this comment.
| parameter_group_name = "example-rds-postgres-pg" | ||
| identifier_prefix = "example-rds-" | ||
| username = "example-tamr-master" | ||
| password = "foo" #tfsec:ignore:GEN003 |
There was a problem hiding this comment.
good choice, since I think this is actually too short of a password to be accepted by RDS (maybe I'm thinking of something else though)
I think we're using the parameter group for setting the database type to postgres and the version. If there's a better way to specify those or there's more we could be doing with it, I'm all for it! |
Ah, yeah I was just curious. But it does look like the |
AWS018andGEN003tfsec warningsNotes about addressing
tfsecwarnings:AWS018Unrelated comment/question: Why are we setting up a db parameter group resource for each db instance when it's not specifying any parameters to apply anyway?