Skip to content

CA-18 RDS Postgres Initial Tests #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
32 commits merged into from Mar 8, 2022
Merged

CA-18 RDS Postgres Initial Tests #24

32 commits merged into from Mar 8, 2022

Conversation

@ghost
Copy link

@ghost ghost commented Mar 3, 2022

Initial tests:

  • creates the RDS instance
  • waits to call the AWS API describe RDS function and asserts values are the same as outputs from terraform.

Also, this PR contains changes in other non-test related files due to running terraform fmt and make terraform/docs

rosemarywang and others added 30 commits July 6, 2020 13:16
@rosemarywang
CI-159 Update Makefile
452767e
@hbarros-caylent
adding first test
293fac6
@hbarros-caylent
adding first test
1e25f16
@hbarros-caylent
simple test
cade63e
@hbarros-caylent
adding helper function for connectivity test
5391968
@hbarros-caylent
Merge tag '2.0.0' into CA-18
89b29a2
@hbarros-caylent
CA-18 adding initial tests
23ff23f
@hbarros-caylent
standard for test_examples folder name
620fa76
@hbarros-caylent
make lint, terraform/docs and fmt
8463d01
@hbarros-caylent
go mod tidy
057d812
@hbarros-caylent
fix comments
7df5db6
@hbarros-caylent
Merge remote-tracking branch 'upstream/master' into CA-18
7195926
@hbarros-caylent
big refactor - test_structure + testCases
d030414
@hbarros-caylent
updating versions
8b97937
@hbarros-caylent
fixes module name
515375f
@hbarros-caylent
CA-71 - update tests/ to instantiate examples/
4762b16
@hbarros-caylent
using expectApplyError
97f5ba6
@hbarros-caylent
1st version of cloudwatch logs integration
bd89420
@hbarros-caylent
adding upgrade logs and updating local.tfvars
3dfcd41
@hbarros-caylent
adding parameter log_statement=all
4eb6a4a
@hbarros-caylent
creates param group log parameters from module variables
14a6138
@hbarros-caylent
Merge tag '3.1.0' into CA-18
7302b65
@hbarros-caylent
fix: adding require lib
2c4bc48
@hbarros-caylent
adding comments
1b10888
@hbarros-caylent
adding test README
049ecc6
@hbarros-caylent
Merge remote-tracking branch 'upstream/master' into CA-18
ac2069f
@hbarros-caylent
smallfix
ecc9d93
@hbarros-caylent
update to README
f420039
@hbarros-caylent
removing local.tfvars
fea9c3f
@hbarros-caylent
reverting change on output
11ba9a2
@ghost ghost added the terratest label Mar 3, 2022
@ghost ghost requested a review from franco-caylent March 3, 2022 19:57
@ghost ghost requested review from a team as code owners March 3, 2022 19:57
franco-martin
franco-martin reviewed Mar 3, 2022
View reviewed changes
franco-martin
franco-martin reviewed Mar 3, 2022
View reviewed changes
Copy link

@franco-martin franco-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, lets see what dan thinks of the outputs

@ghost ghost requested a review from souza-dan March 3, 2022 20:51
souza-dan
souza-dan reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@souza-dan souza-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!

franco-caylent
franco-caylent approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@franco-caylent franco-caylent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost requested a review from souza-dan March 7, 2022 19:45
souza-dan
souza-dan approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@souza-dan souza-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 3a4d53b into Datatamer:master Mar 8, 2022
@ghost ghost deleted the CA-18 branch March 8, 2022 17:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

terratest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@souza-dan @franco-martin @franco-caylent @rosemarywang @hbarros-caylent @joseamoroso