DEV-14200 Add aws_db_subnet_group resource and variable changes #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souza-dan
approved these changes
Sep 10, 2020
CHANGELOG.md
Outdated
| @@ -1,4 +1,10 @@ | |||
| # Tamr Terraform Template Repo | |||
|
|
|||
| ## v0.3.0 - | |||
There was a problem hiding this comment.
Super-nit: Missing date (maybe purposefully until review is over)
jaynathani-tamr
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
LGTM. Only nit changes that @souza-dan requested. Also, I think we are following Fork, Branch, PR workflow for Terraform PRs https://datatamr.atlassian.net/wiki/spaces/DevOps/pages/1225162756/Terraform+Workflow.
Co-authored-by: Dan Souza <dan.souza@tamr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the
aws_db_subnet_groupresource, I assumed that thesubnet_group_nameandrds_subnet_ids(new) vars should be required.