499 inconsistency of api with the ecosystem #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use URLs for images and badges in README.md
…e new parameters and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
valuesandgeometriesparameters to the most important functions and classesPackage version (main branch)
version: 1.1.0
Description
Many functions and classes got new parameters:
valuesandgeometriesfor functions and classes transforming data and experimental semivariogram methods family, andknown_valuesandknown_geometriesfor functions and classes related to kriging.Problem
Previous parameter structure was inconsistent with the packages in the ecosystem.
Solution
See Description.
Affected modules
Blockshas the new parametersvaluesandgeometries, that might be provided instead ofdsparametercalculate_semivariance()function has the new parametersvaluesandgeometries, that might be provided instead ofdsparameterinterpolate_points()function has the new parametersknown_valuesandknown_geometries, that might be provided instead of theknown_locationsparametervalidate_kriging()function has the new parametersknown_valuesandknown_geometries, that might be provided instead of theknown_locationsparametervalidate_kriging()has new parameter:progress_barthat controlstqdmprogress barinverse_distance_weighting()function has the new parametersknown_valuesandknown_geometries, that might be provided instead of theknown_locationsparameterIndicatorKrigingclass has the new parametersknown_valuesandknown_geometries, that might be provided instead of theknown_locationsparameterordinary_kriging()function has the new parametersknown_valuesandknown_geometries, that might be provided instead of theknown_locationsparametersimple_kriging()function has the new parametersknown_valuesandknown_geometries, that might be provided instead of theknown_locationsparameterUniversalKrigingclass has the new parametersknown_valuesandknown_geometries, that might be provided instead of theknown_locationsparameterinblock_semivariance()function is now private:_inblock_semivariance()DirectionalVariogram()class has the new parametersvaluesandgeometries, that might be provided instead ofdsparameterDirectionalVariogram()classExperimentalVariogram()class has the new parametersvaluesandgeometries, that might be provided instead ofdsparameterExperimentalVariogram()classbuild_experimental_variogram()function has the new parametersvaluesandgeometries, that might be provided instead ofdsparameterbuild_experimental_variogram()functionVariogramCloud()class has the new parametersvaluesandgeometries, that might be provided instead ofdsparameterdirectional_weighted_semivariance()function is now private:_directional_weighted_semivariance()omnidirectional_variogram()function is now private:_omnidirectional_variogram()omnidirectional_semivariogram_cloud()function is now private:_omnidirectional_semivariogram_cloud()calculate_covariance()function has the new parametersvaluesandgeometries, that might be provided instead ofdsparameterdirectional_covariance()function is now private:_directional_covariance()omnidirectional_covariance()function is now private:_omnidirectional_covariance()directional_semivariance()function is now private:_directional_semivariance()directional_semivariance_cloud()function is now private:_directional_semivariance_cloud()omnidirectional_semivariance()function is now private:_omnidirectional_semivariance()point_cloud_semivariance()function has the new parametersvaluesandgeometries, that might be provided instead ofdsparametercode_indicator()function has the new parametersvaluesandgeometries, that might be provided instead ofdsparameterExperimentalIndicatorVariogramandIndicatorVariogramDataclasses have the new parametersvaluesandgeometries, that might be provided instead ofdsparameterPointSupporthas the new parametersvaluesandgeometries, that might be provided instead ofdsparameterUnit tests
Package check
(Optional) Additional info
Is feature related to literature? Does change require new dependencies? Any other information...