feat: Improve PixelTransition component accessibility #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds to enable keyboard focus. - Maps onFocus/onBlur to the transition logic for keyboard users. - Renames handleMouseEnter/Leave to handleEnter/Leave for clarity, as they now serve both mouse and keyboard events. - Implements dynamic to ensure screen readers only announce visible content.
- Update content types to React.ReactNode | string to match docs. - Match prop order with propData.
DavidHDev
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the keyboard accessibility enhancements from Issue #622, following up on the
onceprop implementation in #626.It also includes the minor refactors.
Accessibility Changes:
onFocus/onBlurevents.tabIndex={0}.aria-hiddenfor screen readers.Refactoring:
contentprop types toReact.ReactNode | stringto be consistent with the documentation.