Skip to content

Conversation

@DavidVujic
Copy link
Owner

Description

Gather sub dependencies when running poly check from the CLI. This, to allow imports from library sub dependencies in source code.

Example: fastAPI and using Pydantic models should be allowed. Same with Typer and the typing-extensions sub dependency.

Motivation and Context

Making the poly check command behave more correct when analyzing third-party dependencies.

How Has This Been Tested?

✅ CI
✅ Local running manual tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DavidVujic DavidVujic merged commit f15d10d into main Jan 16, 2024
@DavidVujic DavidVujic deleted the cli-poly-check-with-subdependencies branch January 16, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants