Skip to content

Conversation

@DavidVujic
Copy link
Owner

Description

fix(cli): poly libs to collect sub-dependencies, as done in poly check.

Also, handling the collecting differently depending on if the source/origins is from a lock-file or not.
When gathering dependencies form a lock file: sub dependencies are already there.

Motivation and Context

To output more correct result for poly libs and the CLI.

Also, not extracting sub-dependencies when running in a Poetry context.

How Has This Been Tested?

✅ CI
✅ run local CLI commands
✅ Local plugin install and run commands

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DavidVujic DavidVujic merged commit f712ef0 into main Jan 16, 2024
@DavidVujic DavidVujic deleted the cli-poly-libs-with-subdependencies branch January 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants