Skip to content

Conversation

@DavidVujic
Copy link
Owner

@DavidVujic DavidVujic commented Sep 24, 2024

Description

Run poly check and poly libs in strict mode when the collected third-party depencencies is collected from a lock-file.
This will have the same effect as when running the commands with the --strict option.

Motivation and Context

fixes #267 and the issue decribed in #266

How Has This Been Tested?

✅ CI
✅ Local run of poly check and poly libs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@sonarqubecloud
Copy link

@DavidVujic DavidVujic changed the title Deps from lock files use strict feat(poly check, poly libs): use strict mode when dependencies origin from lock file Sep 24, 2024
@DavidVujic DavidVujic marked this pull request as ready for review September 24, 2024 19:30
@DavidVujic DavidVujic merged commit 6ee2002 into main Sep 24, 2024
@DavidVujic DavidVujic deleted the deps-from-lock-files-use-strict branch October 1, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poly check: should use data from project-specific lock files, and not use the loose comparison between names.

2 participants