Skip to content

Conversation

@DavidVujic
Copy link
Owner

@DavidVujic DavidVujic commented Oct 1, 2024

Description

Changing the data type from str to bool for the --verbose option.

Motivation and Context

The str annotation is a typo, the option is meant to be a boolean just like in other commands.

NOTE: this will be a breaking change, for any users using the poly sync --verbose option today. My appologies if this is the case 🙏 . Hopefully this will be a minor thing to adjust (i.e. just use --verbose without any string value).

How Has This Been Tested?

✅ CI
✅ Manual run of the poly sync command from the CLI endpoint.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

@DavidVujic DavidVujic changed the title fix(cli): typo in the poly sync annotation for the --verbose option fix(cli): typo in the poly sync annotation for the --verbose option (BREAKING) Oct 8, 2024
@DavidVujic DavidVujic marked this pull request as ready for review October 8, 2024 08:39
@DavidVujic DavidVujic merged commit d24f893 into main Oct 8, 2024
3 checks passed
@DavidVujic DavidVujic deleted the poly-sync-verbose-typo branch October 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants