Skip to content

Update typing to support python 3.8 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2022
Merged

Update typing to support python 3.8 #29

merged 1 commit into from
Nov 14, 2022

Conversation

@Brejkarn
Copy link
Contributor

@Brejkarn Brejkarn commented Nov 13, 2022

Updated typing and sorted imports

@DavidVujic
Copy link
Owner

DavidVujic commented Nov 14, 2022

Thank you @Brejkarn! ⭐

I guess I went a little bit too fast with the release, without proper testing. I'll merge this one as soon as you think it is ready.

(also added an issue about adding CI steps to verify different Python versions #30 so I won't forget 😄 )

@Brejkarn Brejkarn marked this pull request as ready for review November 14, 2022 08:10
DavidVujic
DavidVujic approved these changes Nov 14, 2022
View reviewed changes
Copy link
Owner

@DavidVujic DavidVujic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@DavidVujic DavidVujic merged commit c88d044 into DavidVujic:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidVujic DavidVujic DavidVujic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Brejkarn @DavidVujic