-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat(poly build): setup and teardown for building, when using Maturin or tools without hook or plugin support #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbde58b to
176e81d
Compare
…ols without support for plugins or build hooks
…ols without support for plugins or build hooks
…ols without support for plugins or build hooks
…ols without support for plugins or build hooks
bb8282b to
cf3d646
Compare
14877dc to
d721e57
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Support for additional Package & Dependency Management tools, primarily Maturin.
Adding a new command -
poly build- that can be used for buildingwheelswhen deploying projects from a Polylith Workspace.Use this command by running the sub-commands:
poly build setuppoly build teardownUsage
Example: with Maturin
(with an activated virtual environment, and the Polylith CLI installed)
The
setupcommand will collect and copy all the needed bricks into the project folder. Using maturin build to create awheel. Finally, theteardowncommand will remove temporary directory (if using custom top namespaces) and the copied bricks folder no longer needed after the wheel is built.The
setupandteardowncommand is basically the same thing happening in the Hatch and PDM hooks. This Pull Request exposes the new CLI command endpoint, extracting the existing build features into a new brick, and adding some command-specific additional path configuration.Motivation and Context
As suggested in the Discussion #297
How Has This Been Tested?
✅ CI
✅ new unit tests
✅ Testing new commands with a locally installed CLI (in a Maturin + Polylith example setup)
✅ Asserting the PDM hooks by installing a local build, and running the
pdm buildcommand (in the pdm example project)✅ Asserting the Hatch hook by installing a local build, and running the
uv buildcommand (in the uv example project)Types of changes
Checklist: