Skip to content

Conversation

@DavidVujic
Copy link
Owner

@DavidVujic DavidVujic commented Feb 21, 2023

Description

fix: normalize third-party library names when comparing what is imported and what is installed (i.e. treat - and _ as same)

fix: use all third-party libraries, and don't filter out them by the "main" category.
NOTE: a trade-off is that the result might be a false-positive, if a dev-dependency would be imported into a brick.

fix: return to stdout (result code 1) when failing to extract libs from projects.

fix: use the project specific poetry.lock file when parsing third-party libraries.

Motivation and Context

Solves parts of #58 - for the poetry poly libs command.
Fixes #57

How Has This Been Tested?

Manually tested
CI ✅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic marked this pull request as ready for review February 21, 2023 19:41
@DavidVujic DavidVujic merged commit 23a8021 into main Feb 21, 2023
@DavidVujic DavidVujic deleted the poly-libs-fixes branch February 21, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Libs command is not working as expected

2 participants