Skip to content

Conversation

@DavidVujic
Copy link
Owner

@DavidVujic DavidVujic commented Mar 4, 2023

Description

The poly check command is now analyzing brick imports - local and third-party - and reports if there is something missing in the projects. It no longer runs the poetry check-project command behind the scenes.

Motivation and Context

The reasoning behind the rework can be found in #58

How Has This Been Tested?

Manual testing in REPL, local install and run on example project(s).
CircleCI ✅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic marked this pull request as ready for review March 4, 2023 15:50
@DavidVujic DavidVujic merged commit 77fa7e4 into main Mar 5, 2023
@DavidVujic DavidVujic deleted the poly-check-with-packages-validation branch March 5, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants