Skip to content

Cleanup state when deleting packs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Cleanup state when deleting packs #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var (
autoYes bool
mcVersionFlag string // override MC version
loaderFlag string // override loader
verbose bool // enable verbose logging
verbose bool // enable verbose logging
)

func main() {
Expand Down Expand Up @@ -278,12 +278,33 @@ func main() {
if err := SaveConfig(cfgFile, cfg); err != nil {
return err
}
fmt.Printf("Deleted modpack %q\n", name)
// Also remove associated state and mods directory?
// state, _ := LoadState(stateFile)
// delete(state, name)
// SaveState(stateFile, state)
// os.RemoveAll(filepath.Join(modsDir, name))
fmt.Printf("Deleted modpack %q from config\n", name)

// --- Remove state entry ---
state, err := LoadState(stateFile)
if err != nil {
fmt.Printf("Warning: could not load state file: %v\n", err)
} else {
if _, ok := state[name]; ok {
delete(state, name)
if err := SaveState(stateFile, state); err != nil {
fmt.Printf("Warning: could not save updated state file: %v\n", err)
} else if verbose {
fmt.Printf("Removed state for %q\n", name)
}
} else if verbose {
fmt.Printf("No state found for %q\n", name)
}
}

// --- Remove mods directory ---
dir := filepath.Join(modsDir, name)
if err := os.RemoveAll(dir); err != nil {
fmt.Printf("Warning: failed to remove mods directory %s: %v\n", dir, err)
} else if verbose {
fmt.Printf("Removed mods directory %s\n", dir)
}

return nil
},
}
Expand Down Expand Up @@ -436,7 +457,7 @@ func main() {
continue
}

// --- Perform Download ---
// --- Perform Download ---

// Remove old file ONLY if it exists AND the new filename is different
if fileExists && expectedFilePath != "" && modState.Filename != ver.Files[0].Filename {
Expand Down Expand Up @@ -490,7 +511,7 @@ func main() {

// check-updates
checkUpdatesCmd := &cobra.Command{
Use: "check-updates [modpack]", // Renamed from "status"
Use: "check-updates [modpack]", // Renamed from "status"
Short: "Check Modrinth for newer versions of mods in a modpack", // Updated description
Args: cobra.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
Expand Down