Optimize map

[edenhaus]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (d82619b) to head (c0dda4d).
Report is 4 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1033      +/-   ##
==========================================
- Coverage   93.77%   93.74%   -0.03%     
==========================================
  Files         129      129              
  Lines        5012     4988      -24     
  Branches      327      327              
==========================================
- Hits         4700     4676      -24     
  Misses        249      249              
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codspeed-hq]

CodSpeed Performance Report

Merging #1033 will not alter performance

_{Comparing optimize-map (c0dda4d) with dev (c40b1e8)}

Summary

✅ 6 untouched benchmarks

[Copilot]

Pull Request Overview

This PR streamlines map rendering by replacing dynamic palettes with compile-time constants, refactors data parsing loops for performance, and optimizes change detection in map pieces.

• Replaced Lazy<Vec<u8>> palettes with const slices and fixed-size transparency arrays
• Switched byte-order reads to from_le_bytes and simplified iteration closures to for loops
• Updated update_points to early-exit on unchanged data and adjusted tests for slice inputs

[Copilot]

The check pixel_idx > MAP_IMAGE_PALETTE_LEN allows pixel_idx == MAP_IMAGE_PALETTE_LEN to slip through, leading to an out-of-bounds palette index. Change the condition to >= to correctly treat indices equal to the palette length as floor.

Suggested change

	let pixel = if pixel_idx > MAP_IMAGE_PALETTE_LEN {
	let pixel = if pixel_idx >= MAP_IMAGE_PALETTE_LEN {

[Copilot]

[nitpick] Pre-allocating based on the string length may over-allocate. Consider using numbers.size_hint() or collecting into a temporary Vec<f32> first to get an accurate capacity estimate.

Suggested change

	let mut points = Vec::with_capacity(subset.coordinates.len() / 2);
	let mut points = Vec::with_capacity(numbers.size_hint().0 / 2);