Skip to content

Conversation

@cyrinux
Copy link
Contributor

@cyrinux cyrinux commented Jul 6, 2025

This bring a better support of my T80 omni model 02qwum.
I try to support more lifespan thing that raise error before.

Copilot AI review requested due to automatic review settings July 6, 2025 15:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the base-file reference in the 02qwum driver to use the 9eamof implementation instead of the outdated ue8kcc version.

  • Updated the file header comment to point at 9eamof.py rather than ue8kcc.py.

@codecov
Copy link

codecov bot commented Jul 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (c61e887) to head (98c031a).
⚠️ Report is 6 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1055   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         130      130           
  Lines        4974     4976    +2     
  Branches      327      327           
=======================================
+ Hits         4660     4662    +2     
  Misses        251      251           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 6, 2025

CodSpeed Performance Report

Merging #1055 will not alter performance

Comparing cyrinux:fix/better-02qwum-support (98c031a) with dev (c61e887)

Summary

✅ 6 untouched benchmarks

@cyrinux cyrinux force-pushed the fix/better-02qwum-support branch 2 times, most recently from db10d86 to df88f43 Compare July 21, 2025 15:56
@cyrinux cyrinux force-pushed the fix/better-02qwum-support branch from df88f43 to 60bec8d Compare July 21, 2025 16:04
@cyrinux cyrinux changed the title fix: better T80 omni (02qwum) support based on 9eamof fix: better T80 omni (02qwum) support based on 9eamof, add more event support Jul 21, 2025
Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cyrinux 👍

@edenhaus edenhaus added the pr: enhancement PR with Improve something label Aug 4, 2025
@edenhaus edenhaus changed the title fix: better T80 omni (02qwum) support based on 9eamof, add more event support Improve support for T80 omni (02qwum) Aug 4, 2025
@edenhaus edenhaus enabled auto-merge (squash) August 4, 2025 13:56
@edenhaus edenhaus merged commit 2b275c1 into DeebotUniverse:dev Aug 4, 2025
27 checks passed
@edenhaus
Copy link
Member

edenhaus commented Aug 4, 2025

After I updated the version in HA, there is still to add support for the new types in HA and provide translations. @cyrinux Can you do that? I plan to release today a new version and create the bump PR. After that one is merged you could open the PR directly in HA

@cyrinux
Copy link
Contributor Author

cyrinux commented Aug 4, 2025

@edenhaus can you tell me more, I'm not sure where i need to do this ? Also not sure I can easily do it.

@edenhaus
Copy link
Member

@cyrinux Sorry missed your comment. Please see home-assistant/core#155238. I did add some but a few are missing. Please feel free to add the others :)
It takes some time to find a nice icon for each of them but please add all if you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement PR with Improve something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants