- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 144
 
Improve support for T80 omni (02qwum) #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for T80 omni (02qwum) #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the base-file reference in the 02qwum driver to use the 9eamof implementation instead of the outdated ue8kcc version.
- Updated the file header comment to point at 9eamof.py rather than ue8kcc.py.
 
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##              dev    #1055   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         130      130           
  Lines        4974     4976    +2     
  Branches      327      327           
=======================================
+ Hits         4660     4662    +2     
  Misses        251      251           
  Partials       63       63           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
          
CodSpeed Performance ReportMerging #1055 will not alter performanceComparing  Summary
  | 
    
db10d86    to
    df88f43      
    Compare
  
    df88f43    to
    60bec8d      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cyrinux 👍
| 
           After I updated the version in HA, there is still to add support for the new types in HA and provide translations. @cyrinux Can you do that? I plan to release today a new version and create the bump PR. After that one is merged you could open the PR directly in HA  | 
    
| 
           @edenhaus can you tell me more, I'm not sure where i need to do this ? Also not sure I can easily do it.  | 
    
| 
           @cyrinux Sorry missed your comment. Please see home-assistant/core#155238. I did add some but a few are missing. Please feel free to add the others :)  | 
    
This bring a better support of my T80 omni model 02qwum.
I try to support more lifespan thing that raise error before.