Skip to content

Conversation

@edenhaus
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings August 11, 2025 13:05
@edenhaus edenhaus added the pr: refactor PR with code refactoring label Aug 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes pylint as a linting tool from the project while keeping ruff and mypy for code quality checks. The change removes pylint-specific configuration and comments while maintaining all other linting tools.

Key changes:

  • Removes pylint dependency and configuration from pyproject.toml
  • Removes pylint-specific disable comments from source code
  • Updates CI/CD pipeline to exclude pylint checks

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

File Description
pyproject.toml Removes pylint dependency and all pylint configuration sections
.pre-commit-config.yaml Removes pylint hook from pre-commit configuration
.github/workflows/ci.yml Removes pylint step from CI workflow
Multiple Python files Removes pylint-specific disable comments while preserving ruff noqa comments

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev@0a503c6). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on dev.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deebot_client/device.py 0.00% 2 Missing ⚠️
deebot_client/authentication.py 0.00% 1 Missing ⚠️
deebot_client/command.py 50.00% 1 Missing ⚠️
deebot_client/mqtt_client.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #1089   +/-   ##
======================================
  Coverage       ?   93.74%           
======================================
  Files          ?      131           
  Lines          ?     5019           
  Branches       ?      327           
======================================
  Hits           ?     4705           
  Misses         ?      251           
  Partials       ?       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@edenhaus edenhaus merged commit 9e26f4e into dev Aug 11, 2025
24 checks passed
@edenhaus edenhaus deleted the remove-pylint branch August 11, 2025 13:33
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 11, 2025

CodSpeed Performance Report

Merging #1089 will not alter performance

Comparing remove-pylint (e3872aa) with dev (f23387a)1

Summary

✅ 6 untouched benchmarks

Footnotes

  1. No successful run was found on dev (659b2a8) during the generation of this report, so f23387a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: refactor PR with code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants