Skip to content

Conversation

@edenhaus
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings August 11, 2025 13:06
@edenhaus edenhaus added the pr: bugfix PR, which fixes a bug label Aug 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a KeyError that occurs when processing map data with empty values in the GetMajorMap command. The fix adds proper handling for empty string values when splitting the comma-separated value string.

  • Adds filtering for empty strings when parsing comma-separated map values
  • Expands test coverage with a parametrized test including an edge case with empty values

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
deebot_client/commands/json/map.py Fixes the KeyError by filtering empty strings when splitting comma-separated values
tests/commands/json/test_map.py Converts test to parametrized format and adds test case for empty value scenario

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dev@0a503c6). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #1091   +/-   ##
======================================
  Coverage       ?   93.74%           
======================================
  Files          ?      131           
  Lines          ?     5019           
  Branches       ?      327           
======================================
  Hits           ?     4705           
  Misses         ?      251           
  Partials       ?       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 11, 2025

CodSpeed Performance Report

Merging #1091 will not alter performance

Comparing fix-getMajorMap-KeyError (f961990) with dev (f23387a)1

Summary

✅ 6 untouched benchmarks

Footnotes

  1. No successful run was found on dev (0a503c6) during the generation of this report, so f23387a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@edenhaus edenhaus merged commit 659b2a8 into dev Aug 11, 2025
27 checks passed
@edenhaus edenhaus deleted the fix-getMajorMap-KeyError branch August 11, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix PR, which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants