Skip to content

Conversation

@Sanji78
Copy link
Contributor

@Sanji78 Sanji78 commented Sep 16, 2025

No description provided.

@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Sep 16, 2025
Copy link
Contributor Author

@Sanji78 Sanji78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing space removed

@edenhaus
Copy link
Member

Could you let me know if you tested this capabilities file with HA?

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.84%. Comparing base (a282ec8) to head (6ec43a2).
⚠️ Report is 1 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1162      +/-   ##
==========================================
+ Coverage   93.78%   93.84%   +0.05%     
==========================================
  Files         132      133       +1     
  Lines        5072     5117      +45     
  Branches      332      332              
==========================================
+ Hits         4757     4802      +45     
  Misses        252      252              
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 16, 2025

CodSpeed Performance Report

Merging #1162 will not alter performance

Comparing Sanji78:dev (6ec43a2) with dev (a282ec8)

Summary

✅ 6 untouched

@Sanji78
Copy link
Contributor Author

Sanji78 commented Sep 16, 2025

Yes I tested it with Home Assistant of course :)
Device is created, I can see all main sensors, events, configuration and diagnostic.

  • For robot state, the PR 1147 works like a charm, but I'm not introducing it yet, cause I see it's not merged
  • For discrete water level, I tested with PR 1100 and it works, but I had to patch select.py in ecovacs component (code is in PR comments)
  • For maps, I still cannot see it, but I see same MQTT data like PR 1083, compressed etc... I'm available to provide test data

@edenhaus
Copy link
Member

  • For discrete water level, I tested with PR 1100 and it works, but I had to patch select.py in ecovacs component (code is in PR comments)

Will be fixed with the next version bump in HA. 1100 is a breaking change as needs updates in the HA code

Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sanji78 👍

@edenhaus edenhaus enabled auto-merge (squash) September 16, 2025 16:21
@edenhaus edenhaus disabled auto-merge September 16, 2025 16:21
@edenhaus edenhaus changed the title Support for X8 Pro Omni Add support for X8 Pro Omni (n0vyif) Sep 16, 2025
@edenhaus edenhaus enabled auto-merge (squash) September 16, 2025 16:22
@edenhaus edenhaus merged commit d6d257f into DeebotUniverse:dev Sep 16, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants