Skip to content

Conversation

@edenhaus
Copy link
Member

@edenhaus edenhaus commented Sep 22, 2025

Ecovacs calls only the vacuum bot as Deebot and as the deebot folder already contains mowers it makes no sense to keep it

Copilot AI review requested due to automatic review settings September 22, 2025 21:01
@edenhaus edenhaus added pr: Breaking Change Pull request with braking changes pr: refactor PR with code refactoring labels Sep 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request restructures the hardware module by moving all files from the nested deebot_client/hardware/deebot/ folder directly into the deebot_client/hardware/ folder.

  • Consolidates the hardware module structure by eliminating the intermediate deebot subfolder
  • Updates all import statements to reference the new flattened structure
  • Moves the deebot-specific hardware logic directly into the main hardware module

Reviewed Changes

Copilot reviewed 7 out of 185 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
deebot_client/hardware/init.py Replaces simple re-export with full hardware logic implementation
deebot_client/hardware/deebot/init.py Removes the nested deebot module entirely
deebot_client/api_client.py Updates import to use flattened hardware module
tests/conftest.py Updates import to use flattened hardware module
tests/hardware/test_init.py Updates imports and references to use flattened hardware module
scripts/check_for_similar_models.py Updates imports and file paths to use flattened hardware module
pyproject.toml Updates configuration path to match new structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.95%. Comparing base (341c25c) to head (ec53b00).
⚠️ Report is 1 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1180      +/-   ##
==========================================
- Coverage   93.95%   93.95%   -0.01%     
==========================================
  Files         136      135       -1     
  Lines        5163     5160       -3     
  Branches      336      336              
==========================================
- Hits         4851     4848       -3     
  Misses        248      248              
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 22, 2025

CodSpeed Performance Report

Merging #1180 will not alter performance

Comparing hardware (ec53b00) with dev (341c25c)

Summary

✅ 6 untouched

@edenhaus edenhaus removed the pr: Breaking Change Pull request with braking changes label Sep 22, 2025
@edenhaus edenhaus merged commit 6366ab3 into dev Sep 22, 2025
28 checks passed
@edenhaus edenhaus deleted the hardware branch September 22, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: refactor PR with code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants