Skip to content

Conversation

@edenhaus
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.18%. Comparing base (f350f82) to head (72898e2).
⚠️ Report is 1 commits behind head on dev.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deebot_client/commands/json/map/__init__.py 50.00% 1 Missing ⚠️
deebot_client/messages/json/map/__init__.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1192      +/-   ##
==========================================
- Coverage   94.18%   94.18%   -0.01%     
==========================================
  Files         138      138              
  Lines        5243     5224      -19     
  Branches      341      341              
==========================================
- Hits         4938     4920      -18     
+ Misses        245      244       -1     
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2025

CodSpeed Performance Report

Merging #1192 will not alter performance

Comparing message_requested_commands (72898e2) with dev (f350f82)

Summary

✅ 7 untouched

@edenhaus edenhaus added pr: enhancement PR with Improve something pr: bugfix PR, which fixes a bug labels Sep 27, 2025
@edenhaus edenhaus marked this pull request as ready for review September 27, 2025 17:36
Copilot AI review requested due to automatic review settings September 27, 2025 17:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the requested_commands field from the deprecated CommandResult class to the HandlingResult class and updates the OnMapSetV2 message handler to request map set updates when processing map set events. This improves the message handling architecture by consolidating command request functionality in a single result type.

  • Remove deprecated CommandResult class and migrate its functionality to HandlingResult
  • Update all command handlers to return HandlingResult instead of CommandResult
  • Enhance OnMapSetV2 to automatically request map set updates using the capabilities system

Reviewed Changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
deebot_client/message.py Add requested_commands field to HandlingResult class
deebot_client/command.py Remove deprecated CommandResult class and update all references to use HandlingResult
deebot_client/messages/json/map/init.py Update OnMapSetV2 to request map set commands based on capabilities
Multiple command files Update return types from CommandResult to HandlingResult throughout codebase
Multiple test files Update test assertions and helper functions to use HandlingResult instead of CommandResult

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@edenhaus edenhaus merged commit a5ef022 into dev Sep 27, 2025
27 of 28 checks passed
@edenhaus edenhaus deleted the message_requested_commands branch September 27, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix PR, which fixes a bug pr: enhancement PR with Improve something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants