-
-
Notifications
You must be signed in to change notification settings - Fork 144
Move requested_commands to HandlingResult and request update on onMapSet_V2 #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1192 +/- ##
==========================================
- Coverage 94.18% 94.18% -0.01%
==========================================
Files 138 138
Lines 5243 5224 -19
Branches 341 341
==========================================
- Hits 4938 4920 -18
+ Misses 245 244 -1
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1192 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves the requested_commands field from the deprecated CommandResult class to the HandlingResult class and updates the OnMapSetV2 message handler to request map set updates when processing map set events. This improves the message handling architecture by consolidating command request functionality in a single result type.
- Remove deprecated
CommandResultclass and migrate its functionality toHandlingResult - Update all command handlers to return
HandlingResultinstead ofCommandResult - Enhance
OnMapSetV2to automatically request map set updates using the capabilities system
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| deebot_client/message.py | Add requested_commands field to HandlingResult class |
| deebot_client/command.py | Remove deprecated CommandResult class and update all references to use HandlingResult |
| deebot_client/messages/json/map/init.py | Update OnMapSetV2 to request map set commands based on capabilities |
| Multiple command files | Update return types from CommandResult to HandlingResult throughout codebase |
| Multiple test files | Update test assertions and helper functions to use HandlingResult instead of CommandResult |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.