Skip to content

Conversation

@edenhaus
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 12, 2025 10:16
@edenhaus edenhaus added the pr: refactor PR with code refactoring label Oct 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the map info processing system to use a proper enum-based approach instead of string constants. The changes improve type safety and code organization by introducing a MapInfoType enum and restructuring the data handling.

  • Replaced string constants with a MapInfoType enum for better type safety
  • Refactored data structure to use HashMap<MapInfoType, Vec<MapInfoTypeDataEntry>> instead of separate fields
  • Consolidated styling configuration into a centralized function with proper data structures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 98.23009% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.33%. Comparing base (021d473) to head (b1cf0a5).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/map/map_info.rs 98.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1229      +/-   ##
==========================================
+ Coverage   94.27%   94.33%   +0.06%     
==========================================
  Files         145      146       +1     
  Lines        5450     5508      +58     
  Branches      347      347              
==========================================
+ Hits         5138     5196      +58     
  Misses        250      250              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 12, 2025

CodSpeed Performance Report

Merging #1229 will not alter performance

Comparing mapinfotype (b1cf0a5) with dev (ea81e1a)

Summary

✅ 9 untouched

@edenhaus edenhaus merged commit 32a4293 into dev Oct 12, 2025
28 checks passed
@edenhaus edenhaus deleted the mapinfotype branch October 12, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: refactor PR with code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants