-
-
Notifications
You must be signed in to change notification settings - Fork 149
Improve Deebot T30C Gen2 (viq3mw) #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Deebot T30C Gen2 (viq3mw) #1310
Conversation
Adds basic implementation for Deebot T30C Gen2. All basic settings should work. The detailed settings are not fully tested. Some settings in the blueprint do not align with the settings on the app. I would appreciate guidance on how to analyze the app's API calls.
|
@MarkusMWolff Would you mind adding a simlink to your config in xztz07.py? Otherwise I will need to wait until your pull gets merged. Thank you in advance! BR |
|
Analysing the API is hard and time-consuming. If you have Apple devices, you can use a man-in-the-middle proxy to analyse the traffic. But you need to install custom certificates and co. Also, the app recently started to add certificate pinning, so it can be tricky. @dermitschi we should not add two different models in the same PR, especially since the T30 and T50 can have different features. By splitting them into two PR it will also help to understand the history in the commits better |
|
@edenhaus I tried to manually manipulate the deebot_client files in my HA test environment. I'am not familiar with python and therefore it is hard for me to completely understand what I need to do. Always trying things but sometimes without success :( I will try again and give some feedback. Also I could directly do a commit in my fork and do a pull-request. But testing is a little problem for me :) Will give my very best. BR |
|
Hi I did some minor improvements. I hope I also fixed the Conversion from symbolic link to actual file now. |
Try to fix prek findings Removed unused import statements and reordered some imports for better organization.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1310 +/- ##
==========================================
+ Coverage 94.66% 94.69% +0.03%
==========================================
Files 150 151 +1
Lines 5899 5942 +43
Branches 350 350
==========================================
+ Hits 5584 5627 +43
Misses 253 253
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1310 will not alter performanceComparing Summary
|
edenhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarkusMWolff 👍
Adds basic implementation for Deebot T30C Gen2. All basic settings should work. The detailed settings are not fully tested. Some settings in the blueprint do not align with the settings on the app. I would appreciate guidance on how to analyze the app's API calls.