fix(dipu): avoid infinite recursion in dumpArg()
#752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens when DIPU_DUMP_OP_ARGS is set to 3, and the tensor is copied from device to CPU before dumping the tensor. This patch uses a function previously used in auto_compare (renamed to `toCpuTensorWithoutDiopiCopy()`) to avoid the infinite recursion.
lljbash
requested review from
fandaoyi,
mrdanielw and
zhaoguochun1995
as code owners
lljbash
force-pushed
the
llj/fix-infinite-copy-dumparg
branch
2 times, most recently
from
79e71b4 to
7fcec94
Compare
fandaoyi
approved these changes
Mar 28, 2024
jfxu-st
approved these changes
Mar 28, 2024
xuq7410
pushed a commit
to xuq7410/deeplink.framework
that referenced
this pull request
May 23, 2024
fix increment coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when DIPU_DUMP_OP_ARGS is set to 3, and the tensor is copied from device to CPU before dumping the tensor.
This patch uses a function previously used in auto_compare (renamed to
toCpuTensorWithoutDiopiCopy()) to avoid the infinite recursion.