[IO] Add Parquet Dataset Support. #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Wanderer
force-pushed
the
parquet
branch
3 times, most recently
from
4d7c6ad to
e3acc98
Compare
Contributor
Author
|
背景：
|
2sin18
requested changes
Jun 24, 2022
| """sed -i.bak 's/type_traits/std::max<int16_t>(sizeof(int16_t), type_traits/g' cpp/src/parquet/column_reader.cc""", | ||
| """sed -i.bak 's/value_byte_size/value_byte_size)/g' cpp/src/parquet/column_reader.cc""", | ||
| ], | ||
| sha256 = "a27971e2a71c412ae43d998b7b6d06201c7a3da382c804dcdc4a8126ccbabe67", |
Collaborator
There was a problem hiding this comment.
Attention: Arrow 4.x is incompatible with Apsara libraries. Compile DeepRec with Apsara should disable the capabilities.
Contributor
Author
There was a problem hiding this comment.
Can I use Arrow 5.x to avoid this?
Collaborator
There was a problem hiding this comment.
@A-Wanderer No, you should add a compiler macro to disable the library if DeepRec must be compiled with apsara libraries.
A-Wanderer
force-pushed
the
parquet
branch
2 times, most recently
from
da64864 to
84344f5
Compare
liutongxuan
approved these changes
Jun 28, 2022
2sin18
approved these changes
Jun 29, 2022
liutongxuan
approved these changes
Jun 29, 2022
liutongxuan
approved these changes
Jun 30, 2022
liutongxuan
approved these changes
Jul 1, 2022
liutongxuan
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.