[Op] Add FP32 fused l2 normalize op and grad op. #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liutongxuan
reviewed
Jul 1, 2022
tensorflow/python/ops/nn_impl.py
Outdated
| @tf_export(v1=["math.l2_normalize", "linalg.l2_normalize", "nn.l2_normalize"]) | ||
| @deprecated_args(None, "dim is deprecated, use axis instead", "dim") | ||
| def l2_normalize(x, axis=None, epsilon=1e-12, name=None, dim=None): | ||
| def l2_normalize(x, axis=None, epsilon=1e-12, do_fusion=True, name=None, dim=None): |
Member
There was a problem hiding this comment.
我建议这里不要在中间位置加参数，这样导致用户不得不改代码。新参数加到dim后面
Member
There was a problem hiding this comment.
我建议这里还是不要改变原有l2_normalize的接口，我们既然新添了v2，就让v2默认打开fusion，并且保持v2有do_fusion这个可配置的参数
Contributor
Author
There was a problem hiding this comment.
v1版本去掉do_fusion只能默认启用或关闭了，那v1在调用v2接口的时候是默认启用还是关闭？
bazel test --action_env=TF_CPP_MIN_VLOG_LEVEL=1 --action_env=TF_CPP_MIN_LOG_LEVEL=0 --flaky_test_attempts 1 --test_output=all --nocache_test_results --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=0 --copt=-march=skylake-avx512 -- //tensorflow/core/kernels:fused_l2_normalize_ops_test
bazel test --action_env=TF_CPP_MIN_VLOG_LEVEL=1 --action_env=TF_CPP_MIN_LOG_LEVEL=0 --flaky_test_attempts 1 --test_output=all --nocache_test_results --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=0 --copt=-march=skylake-avx512 -- //tensorflow/python:nn_test
Duyi-Wang
force-pushed
the
features/fused_l2n
branch
from
1f08039 to
dd05512
Compare
liutongxuan
approved these changes
Jul 11, 2022
liutongxuan
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.