Skip to content

Conversation

@Pwhsky
Copy link
Collaborator

@Pwhsky Pwhsky commented Oct 20, 2025

No description provided.

@Pwhsky Pwhsky requested a review from mirjagranfors October 20, 2025 11:46
Copy link
Collaborator

@mirjagranfors mirjagranfors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First one (231D) looks good. The dataset that is downloaded is a lot larger than the one you show (1764 frames instead of 363). I don't know if we should run all tutorials before uploading to avoid the outputs being different from what you get when you actually run the code?

In the second and third one, you have to check the downloading of the dataset. you download a different one than you want to use later.

In the third one, 231F, After the 2. Load data, you accidentally try to load tif_dir instead of just dir.

@Pwhsky
Copy link
Collaborator Author

Pwhsky commented Oct 20, 2025

Thank you for the critical feedback, I think it's best if we reduce the total dataset to a subset for the large case (i.e 363 frames) and keep the others the way they are, I have added a line in the BF-C2DL-Huh7 example that does this with

movie = movie[:363]

@mirjagranfors
Copy link
Collaborator

It looks quite good now!

If you only keep the first 363 frames, it won’t really change the training (since you only use one crop anyway), but it will affect the final plot. When only using the first 363 frames, the last plot will then only show four cells, which makes the result look less impressive, and you probably have to tune alpha and the cutoff.

Also, I think this part:
dataset_path = "cell_detection_dataset"
if not os.path.exists(dataset_path):
should include the dataset name, e.g.
dataset_path = "cell_detection_dataset/PhC-C2DL-PSC"
Otherwise, once the main folder is created, the other datasets won’t be downloaded when running the other tutorials.

I’d suggest running the script once before uploading. That way the outputs will match what users get when following the tutorial, and it also helps catch small issues like the ones I’ve mentioned.

@giovannivolpe giovannivolpe merged commit d03d286 into develop Oct 27, 2025
25 checks passed
@giovannivolpe giovannivolpe deleted the al/lodestar-examples-update branch October 27, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants