Skip to content

Fix/nest credit apy simple #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2025
Merged

Fix/nest credit apy simple #2196

merged 3 commits into from
Nov 25, 2025
+57 −0

Conversation

@kristinatub
Copy link
Contributor

@kristinatub kristinatub commented Nov 11, 2025

No description provided.

@kristinatub
Fix nest-credit adaptor: add APY logic and required fields
fd69967 
- Set apyBase to 7-day APY (rolling7d), fallback to 0 if empty
- Add required 'project' field set to 'nest-credit'
- Add live=true parameter to API URL
- Handle empty/missing APY values gracefully
@kristinatub
Merge branch 'DefiLlama:master' into fix/nest-credit-apy-simple
5b8da40
@llamatester
Copy link

llamatester commented Nov 11, 2025

The nest-credit adapter exports pools:

Test Suites: 1 passed, 1 total
Tests: 63 passed, 63 total
Snapshots: 0 total
Time: 0.262 s
Ran all test suites.

Nb of pools: 10
 

Sample pools:
┌─────────┬──────────────────────────────────────────────┬─────────┬───────────────┬───────────┬────────────────────┬────────────────────┬──────────────────────────────────────────────────────────┬──────────────────┐
│ (index) │ pool                                         │ chain   │ project       │ symbol    │ tvlUsd             │ apyBase            │ url                                                      │ underlyingTokens │
├─────────┼──────────────────────────────────────────────┼─────────┼───────────────┼───────────┼────────────────────┼────────────────────┼──────────────────────────────────────────────────────────┼──────────────────┤
│ 0       │ '0x11113ff3a60c2450f4b22515cb760417259ee94b' │ 'Plume' │ 'nest-credit' │ 'NBASIS'  │ 19524905.6144021   │ 3.2452167532261322 │ 'https://app.nest.credit/vault/nest-basis-vault'         │ []               │
│ 1       │ '0x64ab176c545bb85eca75d53c3ffcb361deafb855' │ 'Plume' │ 'nest-credit' │ 'INALPHA' │ 11124989           │ 1.2492017744527129 │ 'https://app.nest.credit/vault/nest-alpha-lp-vault'      │ []               │
│ 2       │ '0xe72fe64840f4ef80e3ec73a1c749491b5c938cb9' │ 'Plume' │ 'nest-credit' │ 'NTBILL'  │ 10761932.897908    │ 4.820205598703375  │ 'https://app.nest.credit/vault/nest-treasury-vault'      │ []               │
│ 3       │ '0xbfc5770631641719cd1cf809d8325b146aed19de' │ 'Plume' │ 'nest-credit' │ 'NINSTO'  │ 6096026.925131     │ 2.1157621860419473 │ 'https://app.nest.credit/vault/nest-institutional-vault' │ []               │
│ 4       │ '0x593ccca4c4bf58b7526a4c164ceef4003c6388db' │ 'Plume' │ 'nest-credit' │ 'NALPHA'  │ 4023672.1212682    │ 7.167032070096124  │ 'https://app.nest.credit/vault/nest-alpha-vault'         │ []               │
│ 5       │ '0x9d08946ca5856f882a56c29042fbedc5142663b9' │ 'Plume' │ 'nest-credit' │ 'NMNRL'   │ 1635744.003088     │ 10.938745835442365 │ 'https://app.nest.credit/vault/nest-mineral-vault'       │ []               │
│ 6       │ '0xa5f78b2a0ab85429d2dfbf8b60abc70f4cec066c' │ 'Plume' │ 'nest-credit' │ 'NCREDIT' │ 386524.174336      │ 0                  │ 'https://app.nest.credit/vault/nest-credit-vault'        │ []               │
│ 7       │ '0x9fbc367b9bb966a2a537989817a088afcaffdc4c' │ 'Plume' │ 'nest-credit' │ 'NELIXIR' │ 113323.14199999999 │ 0                  │ 'https://app.nest.credit/vault/nest-elixir-vault'        │                  │
│ 8       │ '0x29bf22381a5811dec89dc7b46a5ce57ad02c0240' │ 'Plume' │ 'nest-credit' │ 'NWISDOM' │ 58430.343453       │ 0                  │ 'https://app.nest.credit/vault/nest-wisdom-vault'        │ []               │
│ 9       │ '0x2a3e301dbd45c143dfbb7b1ce1c55bf0bbf161cb' │ 'Plume' │ 'nest-credit' │ 'NACRDX'  │ 2                  │ 0                  │ 'https://app.nest.credit/vault/nest-acrdx-vault'         │ []               │
└─────────┴──────────────────────────────────────────────┴─────────┴───────────────┴───────────┴────────────────────┴────────────────────┴──────────────────────────────────────────────────────────┴──────────────────┘
This adapter contains some pools with <10k TVL, these pools won't be shown in DefiLlama

@kristinatub
Copy link
Contributor Author

kristinatub commented Nov 19, 2025

Hi team can you explain this issue? Looks like the The nest-credit adapter exports pools looks fine

@llamatester
Copy link

llamatester commented Nov 24, 2025

The nest-credit adapter exports pools:

Test Suites: 1 passed, 1 total
Tests: 81 passed, 81 total
Snapshots: 0 total
Time: 0.264 s
Ran all test suites.

Nb of pools: 13
 

Sample pools:
┌─────────┬──────────────────────────────────────────────┬─────────┬───────────────┬───────────┬────────────────────┬─────────────────────┬──────────────────────────────────────────────────────────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ (index) │ pool                                         │ chain   │ project       │ symbol    │ tvlUsd             │ apyBase             │ url                                                      │ underlyingTokens                                                                                                                             │
├─────────┼──────────────────────────────────────────────┼─────────┼───────────────┼───────────┼────────────────────┼─────────────────────┼──────────────────────────────────────────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ 0       │ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f' │ 'Plume' │ 'nest-credit' │ 'PUSD'    │ 26774186.637       │ 0                   │ 'https://app.nest.credit/vault/plume-usd-vault'          │ [ '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ]                                               │
│ 1       │ '0x11113ff3a60c2450f4b22515cb760417259ee94b' │ 'Plume' │ 'nest-credit' │ 'NBASIS'  │ 24782813.708       │ 0                   │ 'https://app.nest.credit/vault/nest-basis-vault'         │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 2       │ '0x64ab176c545bb85eca75d53c3ffcb361deafb855' │ 'Plume' │ 'nest-credit' │ 'INALPHA' │ 11119147.0113907   │ -2.192210128030314  │ 'https://app.nest.credit/vault/nest-alpha-lp-vault'      │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x222365ef19f7947e5484218551b56bb3965aa7af' ]                                               │
│ 3       │ '0xbfc5770631641719cd1cf809d8325b146aed19de' │ 'Plume' │ 'nest-credit' │ 'NINSTO'  │ 6094837.7115814    │ -2.5309613299234646 │ 'https://app.nest.credit/vault/nest-institutional-vault' │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 4       │ '0x593ccca4c4bf58b7526a4c164ceef4003c6388db' │ 'Plume' │ 'nest-credit' │ 'NALPHA'  │ 4087212.8456530003 │ 8.168578349090595   │ 'https://app.nest.credit/vault/nest-alpha-vault'         │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 5       │ '0x9d08946ca5856f882a56c29042fbedc5142663b9' │ 'Plume' │ 'nest-credit' │ 'NMNRL'   │ 1642252.2070789998 │ 10.893071355850292  │ 'https://app.nest.credit/vault/nest-mineral-vault'       │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x222365ef19f7947e5484218551b56bb3965aa7af', '0x78add880a697070c1e765ac44d65323a0dcce913' ] │
│ 6       │ '0x119dd7daff816f29d7ee47596ae5e4bdc4299165' │ 'Plume' │ 'nest-credit' │ 'NOPAL'   │ 1399389.822618     │ 4.0029206685790575  │ 'https://app.nest.credit/vault/nest-opal-vault'          │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x222365ef19f7947e5484218551b56bb3965aa7af', '0x78add880a697070c1e765ac44d65323a0dcce913' ] │
│ 7       │ '0xe72fe64840f4ef80e3ec73a1c749491b5c938cb9' │ 'Plume' │ 'nest-credit' │ 'NTBILL'  │ 492292.979946      │ 54.52426498034768   │ 'https://app.nest.credit/vault/nest-treasury-vault'      │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 8       │ '0xa5f78b2a0ab85429d2dfbf8b60abc70f4cec066c' │ 'Plume' │ 'nest-credit' │ 'NCREDIT' │ 320401.724833      │ 0.09047737978882253 │ 'https://app.nest.credit/vault/nest-credit-vault'        │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 9       │ '0x9fbc367b9bb966a2a537989817a088afcaffdc4c' │ 'Plume' │ 'nest-credit' │ 'NELIXIR' │ 106168.462         │ 0                   │ 'https://app.nest.credit/vault/nest-elixir-vault'        │                                                                                                                                              │
└─────────┴──────────────────────────────────────────────┴─────────┴───────────────┴───────────┴────────────────────┴─────────────────────┴──────────────────────────────────────────────────────────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
This adapter contains some pools with <10k TVL, these pools won't be shown in DefiLlama

@kristinatub
Copy link
Contributor Author

kristinatub commented Nov 24, 2025

Hi team can you please merge

@llamatester
Copy link

llamatester commented Nov 25, 2025

The nest-credit adapter exports pools:

Test Suites: 1 passed, 1 total
Tests: 81 passed, 81 total
Snapshots: 0 total
Time: 0.268 s
Ran all test suites.

Nb of pools: 13
 

Sample pools:
┌─────────┬──────────────────────────────────────────────┬─────────┬───────────────┬───────────┬────────────────────┬─────────────────────┬──────────────────────────────────────────────────────────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ (index) │ pool                                         │ chain   │ project       │ symbol    │ tvlUsd             │ apyBase             │ url                                                      │ underlyingTokens                                                                                                                             │
├─────────┼──────────────────────────────────────────────┼─────────┼───────────────┼───────────┼────────────────────┼─────────────────────┼──────────────────────────────────────────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ 0       │ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f' │ 'Plume' │ 'nest-credit' │ 'PUSD'    │ 26755720.33        │ 0                   │ 'https://app.nest.credit/vault/plume-usd-vault'          │ [ '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ]                                               │
│ 1       │ '0x11113ff3a60c2450f4b22515cb760417259ee94b' │ 'Plume' │ 'nest-credit' │ 'NBASIS'  │ 24886267.622       │ 0                   │ 'https://app.nest.credit/vault/nest-basis-vault'         │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 2       │ '0x64ab176c545bb85eca75d53c3ffcb361deafb855' │ 'Plume' │ 'nest-credit' │ 'INALPHA' │ 11119574.011468    │ -1.9962536893460836 │ 'https://app.nest.credit/vault/nest-alpha-lp-vault'      │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x222365ef19f7947e5484218551b56bb3965aa7af' ]                                               │
│ 3       │ '0xbfc5770631641719cd1cf809d8325b146aed19de' │ 'Plume' │ 'nest-credit' │ 'NINSTO'  │ 6084968.1714719    │ -1.7327755964200997 │ 'https://app.nest.credit/vault/nest-institutional-vault' │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 4       │ '0x593ccca4c4bf58b7526a4c164ceef4003c6388db' │ 'Plume' │ 'nest-credit' │ 'NALPHA'  │ 4091403.2996485    │ 10.052403891712402  │ 'https://app.nest.credit/vault/nest-alpha-vault'         │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 5       │ '0x9d08946ca5856f882a56c29042fbedc5142663b9' │ 'Plume' │ 'nest-credit' │ 'NMNRL'   │ 1642252.2070789998 │ 10.893071355850292  │ 'https://app.nest.credit/vault/nest-mineral-vault'       │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x222365ef19f7947e5484218551b56bb3965aa7af', '0x78add880a697070c1e765ac44d65323a0dcce913' ] │
│ 6       │ '0x119dd7daff816f29d7ee47596ae5e4bdc4299165' │ 'Plume' │ 'nest-credit' │ 'NOPAL'   │ 1400980.2681900002 │ 10.266321636252872  │ 'https://app.nest.credit/vault/nest-opal-vault'          │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x222365ef19f7947e5484218551b56bb3965aa7af', '0x78add880a697070c1e765ac44d65323a0dcce913' ] │
│ 7       │ '0xe72fe64840f4ef80e3ec73a1c749491b5c938cb9' │ 'Plume' │ 'nest-credit' │ 'NTBILL'  │ 502707.709946      │ 54.52426498034768   │ 'https://app.nest.credit/vault/nest-treasury-vault'      │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 8       │ '0xa5f78b2a0ab85429d2dfbf8b60abc70f4cec066c' │ 'Plume' │ 'nest-credit' │ 'NCREDIT' │ 302996.724833      │ 0.09047737978882253 │ 'https://app.nest.credit/vault/nest-credit-vault'        │ [ '0xdddd73f5df1f0dc31373357beac77545dc5a6f3f', '0x78add880a697070c1e765ac44d65323a0dcce913', '0x222365ef19f7947e5484218551b56bb3965aa7af' ] │
│ 9       │ '0x9fbc367b9bb966a2a537989817a088afcaffdc4c' │ 'Plume' │ 'nest-credit' │ 'NELIXIR' │ 106168.462         │ 0                   │ 'https://app.nest.credit/vault/nest-elixir-vault'        │                                                                                                                                              │
└─────────┴──────────────────────────────────────────────┴─────────┴───────────────┴───────────┴────────────────────┴─────────────────────┴──────────────────────────────────────────────────────────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
This adapter contains some pools with <10k TVL, these pools won't be shown in DefiLlama

@slasher125 slasher125 merged commit 7609cff into DefiLlama:master Nov 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kristinatub @llamatester @slasher125