Skip to content

Use LocalFilters in terrain functions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Use LocalFilters in terrain functions #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59a567a
Use LocalFilters in terrain functions. Fix skb. Use approximate circu…
evetion Nov 2, 2022
3bb64c7
Small cleanup.
evetion Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "GeoArrayOps"
uuid = "e6005643-8f00-58df-85c5-7d93a3520d70"
authors = ["Maarten Pronk <git@evetion.nl>", "Deltares"]
version = "0.4.0"
version = "0.5.0"

[deps]
DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
Expand Down
2 changes: 1 addition & 1 deletion src/GeoArrayOps.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export pmf, smf, psf
export pssm
export pitremoval
export spread, spread2
export roughness, TRI, TPI, slope, aspect, curvature, hillshade
export roughness, TRI, TPI, slope, aspect, curvature, hillshade, multihillshade
export skb, skbr

end # module
5 changes: 1 addition & 4 deletions src/skew.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Improved the performance by applying a binary search to find the threshold value

[^bartels2006]: Bartels, M., Hong Wei, and D.C. Mason. 2006. “DTM Generation from LIDAR Data Using Skewness Balancing.” In 18th International Conference on Pattern Recognition (ICPR’06), 1:566–69. https://doi.org/10/cwk4v2.
"""
function skb(iA::AbstractArray{T}; mean::T) where {T<:Real}
function skb(iA::AbstractArray{T}; mean::T=mean(iA)) where {T<:Real}
m = .!isfinite.(iA)
if sum(m) > 0
A = copy(iA)
Expand Down Expand Up @@ -45,9 +45,6 @@ function skb(iA::AbstractArray{T}; mean::T) where {T<:Real}
return m
end

function skb(A::AbstractArray{T}) where {T<:Real}
return skb(A; mean=mean(A))
end

"""
mask = skbr(A; iterations=10)
Expand Down
Loading