Skip to content

Conversation

@JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Dec 13, 2024

Fixes #1329

Description

Adds data for tutorial 03. This tutorial will be part of the iMOD Documentation.
Data will be unzipped in a directory chosen by the user.

So it should be used as follows in the tutorial:

import imod

directory = r"\path\to\dir"

# download data
prj_path = imod.data.tutorial_03(directory)

# open_data
imod5_data, period_data = imod.prj.open_projectfile_data(prj_path)

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

path = Path(path)
filename = "iMOD-Documentation-tutorial_03.zip"
lock = FileLock(REGISTRY.path / f"{filename}.lock")
with lock:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the path provided to this method unique? Otherwise there can still be a race condition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

@sonarqubecloud
Copy link

@JoerivanEngelen JoerivanEngelen added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit fb5c786 Dec 13, 2024
7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1329_dsd_tutorial_3_material branch December 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload DSD tutorial material data to artifacts

3 participants