Skip to content

refactor TranslationContext #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Demivan merged 3 commits into from
Apr 12, 2021
Merged

refactor TranslationContext #483

Demivan merged 3 commits into from
Apr 12, 2021

Conversation

@davidrios
Copy link
Contributor

@davidrios davidrios commented Apr 12, 2021

No description provided.

davidrios and others added 3 commits April 11, 2021 18:36
@davidrios
fix: refactor format and formatAttrs and use it in the directive
56c3d56
@Demivan
chore: code cleanup
2e324e7
@davidrios
fix: make TranslationContext API more consistent
f08d61f 
- private _format* methods will return null when no translation was found
- public format* methods will never return null
@Demivan Demivan merged commit 9ac1cb9 into fluent-vue:develop Apr 12, 2021
@Demivan
Copy link
Member

Demivan commented Apr 12, 2021

Thanks

@Demivan Demivan added Type: Feature Includes new features Type: Refactoring A code change that neither fixes a bug nor adds a feature and removed Type: Feature Includes new features labels Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Type: Refactoring A code change that neither fixes a bug nor adds a feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidrios @Demivan