Cache API keys: 2nd attempt #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to see how many cache hits there are for a request
This replaces the previous method of checking if the user had an API key. This makes no sense, as we only get the user by looking up an API key, so the check didn't do anything. Also, we have a situation where any authenticated user has access to all API endpoints, so we only need to return True if we have a user that's authenticated
Fixes #9
On a dev deploy, Djanog is mounted on [url]/Prod/, but Django still links to /static. This change tells Django that static files should be at /Prod/static/
michaeljcollinsuk
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.