This repository was archived by the owner on Dec 14, 2022. It is now read-only.
HW2 is completed #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agneum
suggested changes
Jun 27, 2022
Collaborator
agneum
left a comment
agneum
left a comment
There was a problem hiding this comment.
Спасибо за выполненное задание.
Хорошая работа, однако возвращаю решение на доработку, поскольку не хватает новых юнит-тестов
Итого: 5 баллов из 10
| @@ -1,12 +1,59 @@ | |||
| package hw02unpackstring | |||
| package main | |||
Collaborator
There was a problem hiding this comment.
После такого переименования пакет станет недоступным для импорта.
Если идея была проверить работоспособность функции, то для этого лучше использовать тесты
| return "", nil | ||
| func isValidStr(runesArray []rune) bool { | ||
| var previousIsDigit bool | ||
| for key, char := range runesArray { |
Collaborator
There was a problem hiding this comment.
Предлагаю проверки перенести в один общий цикл, чтобы не перебирать строку дважды
| for key, char := range runesArray { | ||
| currentSymbol := string(char) | ||
| if unicode.IsDigit(char) && buf != "" && buf != "\\" { | ||
| countRepeat, _ := strconv.Atoi(currentSymbol) |
| @@ -1,4 +1,4 @@ | |||
| package hw02unpackstring | |||
| package main | |||
Collaborator
There was a problem hiding this comment.
Не хватает новых юнит-тестов
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Домашнее задание №2 «Распаковка строки»
Чек-лист студента (Что это?)
go mod tidy..syncфайл. Зачем его удалять?Критерии оценки
Зачёт от 7 баллов