Ethnic origin page #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abalanuk
reviewed
Jun 30, 2022
Collaborator
|
Please move all images into |
abalanuk
reviewed
Jun 30, 2022
abalanuk
reviewed
Jun 30, 2022
abalanuk
reviewed
Jun 30, 2022
abalanuk
reviewed
Jun 30, 2022
abalanuk
reviewed
Jun 30, 2022
abalanuk
reviewed
Jun 30, 2022
abalanuk
reviewed
Jun 30, 2022
abalanuk
reviewed
Jun 30, 2022
index3.html
Outdated
| <img src="assets/logo.jpg"> | ||
| </div> | ||
| <div class="menu"> | ||
| <span>Дерево</span> |
…sition: relative' style to position child relatively to his parent container.Refactoring header with with ul+li.
abalanuk
reviewed
Jul 21, 2022
index3.html
Outdated
| <h4> | ||
| <a href="">Домашня сторінка</a> | ||
| </h4> | ||
| <h5> |
Collaborator
There was a problem hiding this comment.
This is not correct. Do not use h5 as a wrapper for a bunch of other elements
Collaborator
There was a problem hiding this comment.
Look how they do it: div -> ul -> li -> a
Here the link/anchor is not by semantic meaning is really heading, so why to wrap it by h4, just add for instance one class to add styles for all "first-items" in each column: Домашня сторінка, Про нас, Пидтримка
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.