Switch to sass from node-sass to widen node version support #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sekwah <contact@sekwah.com>
Signed-off-by: Sekwah <contact@sekwah.com>
The tests generally seem to fail as there isnt a test script in package.json but don't seem to cause the pipeline to fail in older versions. Signed-off-by: Sekwah <contact@sekwah.com>
Contributor
Author
|
Might want to look into this @stevespringett but there isn't a test script in the package.json. Just went back to look at past pr's and it just doesn't exist and doesn't fail despite the error message. Its only in node 16 that they seem to return that the not found exists with a proper error code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #117 which is not supported in the current automated builds.
Doesn't seem to cause any issues and in the past, I've swapped it out and it's been fine.
Though there are a few deprecation warnings it does state in all of the files what needs to be switched and they are all within font awesome not using updated SCSS generally. The new one is documented here https://sass-lang.com/documentation/breaking-changes/slash-div though they could probably use just raw css calc.
Though if it gets dropped before they update it would be a simple pr to font-awesome to fix.