Add author field to components details dialog #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Wolf <stephan.wolf@kontron-ais.com>
stephan-wolf-ais
force-pushed
the
feature-show-author-in-details-dialog
branch
from
1bf6371 to
4fb4b71
Compare
Signed-off-by: Stephan Wolf <stephan.wolf@kontron-ais.com>
Author
|
Hi, the static code complainment make no sense on this small code change. What do you think? |
nscuro
approved these changes
Jul 5, 2022
Member
nscuro
left a comment
nscuro
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Yeah, the Codacy complaint is nothing to worry about here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #181 related to PR 1727 of apiserver